RFR(S): 8145345: LogCompilation output is empty after JEP165: Compiler Control

[Nils Eliasson]

Vladimir,

Consider -XX:+LogCompilation 
-XX:CompileCommand=log,apatternthatmaynevermatch.amethod

LogCompilation will be on, but the LogOption (set by command or 
directive) will be false. The logs will still contain nmethod installs 
and compilation statistics. That's why no tests using LogCompilation 
failed - they all use the information in the compilation statistics.

Regards,
Nils

On 2015-12-15 23:57, Vladimir Kozlov wrote:
> Nils,
>
> Should you also check (!LogOption && LogCompilation) "compilation 
> logging should be enabled if LogCompilation is set"?
>
> Thanks,
> Vladimir
>
> On 12/15/15 4:22 AM, Nils Eliasson wrote:
>> Hi,
>>
>> Please review this change that fixes log compilation. It changed the 
>> default value for the log option to the command
>> line flag value in compilerDirectives.hpp, updates how 
>> CompileCommand=log updates the value, and adds a warning if per
>> method logging is used but LogCompilation is not set.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8145345
>> Webrev: http://cr.openjdk.java.net/~neliasso/8145345/webrev.01/
>>
>> Regards,
>> Nils Eliasson