RFR(S): 8145345: LogCompilation output is empty after JEP165: Compiler Control

[Nils Eliasson]

Thank you Vladimir!

Best regards,
Nils

On 2015-12-16 21:53, Vladimir Kozlov wrote:
> On 12/16/15 12:50 PM, Nils Eliasson wrote:
>>
>> On 2015-12-16 21:26, Vladimir Kozlov wrote:
>>> On 12/16/15 5:37 AM, Nils Eliasson wrote:
>>>> Vladimir,
>>>>
>>>> Consider -XX:+LogCompilation 
>>>> -XX:CompileCommand=log,apatternthatmaynevermatch.amethod
>>>>
>>>> LogCompilation will be on, but the LogOption (set by command or 
>>>> directive) will be false. The logs will still contain
>>>> nmethod installs and compilation statistics. That's why no tests 
>>>> using LogCompilation failed - they all use the
>>>> information in the compilation statistics.
>>>
>>> Are you saying that it is acceptable case (LogCompilation=true && 
>>> LogOption=false)? That is why you don't want
>>> additionla assert I suggested?
>>
>> Yes, it is an acceptable case.
>
> Fine.
>
>>
>>> Current assert only fail when (LogCompilation=false && 
>>> LogOption=true) which is not related to this bug failure.
>> Assert? Do you mean this check:
>
> Yes, this one.
>
>>
>> *+ if (LogOption && !LogCompilation) {*
>> *+ st->print_cr("Warning: +LogCompilation must be set to enable 
>> compilation logging from directives");*
>> *+ } *
>>
>> There is a similar check and warning for compile commands, I added 
>> the same for directives.
>
> Okay.
>
> Thanks,
> Vladimir
>
>>
>> Thanks,
>> Nils
>>
>>
>>>
>>> Thanks,
>>> Vladimir
>>>
>>>>
>>>> Regards,
>>>> Nils
>>>>
>>>> On 2015-12-15 23:57, Vladimir Kozlov wrote:
>>>>> Nils,
>>>>>
>>>>> Should you also check (!LogOption && LogCompilation) "compilation 
>>>>> logging should be enabled if LogCompilation is set"?
>>>>>
>>>>> Thanks,
>>>>> Vladimir
>>>>>
>>>>> On 12/15/15 4:22 AM, Nils Eliasson wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Please review this change that fixes log compilation. It changed 
>>>>>> the default value for the log option to the command
>>>>>> line flag value in compilerDirectives.hpp, updates how 
>>>>>> CompileCommand=log updates the value, and adds a warning if per
>>>>>> method logging is used but LogCompilation is not set.
>>>>>>
>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8145345
>>>>>> Webrev: http://cr.openjdk.java.net/~neliasso/8145345/webrev.01/
>>>>>>
>>>>>> Regards,
>>>>>> Nils Eliasson
>>>>
>>