RFR: 143072: [JVMCI] Port JVMCI to AArch64

Christian Thalinger christian.thalinger at oracle.com
Mon Dec 21 06:42:46 UTC 2015


Alright, here is what I would like to integrate:

http://cr.openjdk.java.net/~twisti/8143072/webrev.01/

There are not many source changes but I wanted to send a webrev anyway.

You will notice that the test changes are gone.  That’s because of the unfortunate situation with the open and closed AArch64 port.  Before I haven’t found a way to reuse the open AArch64 JVMCI changes with our closed port I can’t enable the tests on AArch64 because we would see all of them fail.  And I really want to avoid to copy the files verbatim into our closed port.

I hope you are okay with that for a little while.

> On Dec 18, 2015, at 3:01 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
> 
> Hmm.  My build of open AArch64 crashes either with:
> 
> #  SIGSEGV (0xb) at pc=0x0000ffff9c08f694, pid=18650, tid=18651
> #
> # JRE version: OpenJDK Runtime Environment (9.0) (build 9-internal+0-2015-12-18-163208.root.hs-comp-openjdk)
> # Java VM: OpenJDK 64-Bit Server VM (9-internal+0-2015-12-18-163208.root.hs-comp-openjdk, mixed mode, tiered, compressed oops, g1 gc, linux-aarch64)
> # Problematic frame:
> # j  java.lang.invoke.MemberName$Factory.newMemberBuffer(I)[Ljava/lang/invoke/MemberName;+18
> 
> or
> 
> #  SIGSEGV (0xb) at pc=0x0000ffff8c31761c, pid=18763, tid=18764
> #
> # JRE version: OpenJDK Runtime Environment (9.0) (build 9-internal+0-2015-12-18-163208.root.hs-comp-openjdk)
> # Java VM: OpenJDK 64-Bit Server VM (9-internal+0-2015-12-18-163208.root.hs-comp-openjdk, mixed mode, tiered, compressed oops, g1 gc, linux-aarch64)
> # Problematic frame:
> # v  ~RuntimeStub::g1_post_barrier_slow Runtime1 stub
> 
> Parallel GC works.  Maybe I screwed up the merge.  Could some please check?
> 
>> On Dec 17, 2015, at 2:01 PM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>> 
>> Quick update on this one.  I am trying to get the AArch64 Graal port building using your patch.  I had to make smaller changes to your code and once I have it working I will push this to hs-comp.
>> 
>>> On Dec 2, 2015, at 8:49 AM, Christian Thalinger <christian.thalinger at oracle.com> wrote:
>>> 
>>>> 
>>>> On Dec 2, 2015, at 2:22 AM, Andrew Haley <aph at redhat.com> wrote:
>>>> 
>>>> On 02/12/15 12:09, Roland Schatz wrote:
>>>>> On 12/02/2015 12:33 PM, Andrew Haley wrote:
>>>>>> On 02/12/15 11:23, Roland Schatz wrote:
>>>>>>> Perhaps we should have a series of test analogous to the
>>>>>>> test/compiler/jvmci/errors tests, but for "working" instead of "broken"
>>>>>>> code installation. For that we would need a platform dependent "fake"
>>>>>>> compiler (e.g. handwritten assembly for well-known test methods).
>>>>>> Maybe.  But if there is no way to actually exercise the code which
>>>>>> is in HotSpot, why is it there?
>>>>> It's an interface for compilers. You can exercise the code, you just 
>>>>> have to write a compiler ;)
>>>> 
>>>> Sure, but I don't see why we can't have a tiny compiler in the test
>>>> suite.
>>> 
>>> Wow.  This is getting crazy now :-)
>>> 
>>> Anyway, let’s push what we have now and wait for the AArch64 backend to be functional.  Then we can fix the CodeInstaller methods.
>>> 
>>>> 
>>>> Andrew.
>> 
> 



More information about the hotspot-compiler-dev mailing list