RFR(M): 8069412 : Locks need better debug-printing support

[David Chase]

On 2015-02-17, at 11:03 AM, Roland Westrelin <roland.westrelin at oracle.com> wrote:

>> http://cr.openjdk.java.net/~drchase/8069412/webrev.04/
> 
> That looks good to me.
> 
> LogParser.java
> Is this change to make the LogCompilation tool parse older version of the log file?

That is correct, and I will change the comment to

// Log files from older hotspots may lack inline_id, and zero is an acceptable substitute
// that allows processing to continue.

I could log a "Missing inline_id, substituting zero" to System.err if you think that is appropriate.
I think it's generally semi-bogus that the default behavior from this tool for a missing attribute is
to explode and fail.

David

> 475             long inlineId = 0;
> 476             try {
> 477                 Long.parseLong(search(atts, "inline_id"));
> 478             } catch (InternalError ex) {
> 479                 // 0 is an acceptable default value.
> 480             }
> 
> If that is the case, a better comment would be nice.
> 
> Roland.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20150217/58f21b1c/signature.asc>