[9] RFR(S): 8073670: TypeF::eq and TypeD::eq do not handle NaNs correctly

[Vitaly Davidovich]

Looks good.  I don't have an OpenJDK id, so don't worry about the
reviewed-by section :).

sent from my phone
On Feb 27, 2015 7:33 AM, "Zoltán Majó" <zoltan.majo at oracle.com> wrote:

> Hi Vitaly,
>
>
> On 02/27/2015 01:46 AM, Vitaly Davidovich wrote:
>
>> Unless I'm overlooking something, can't these methods use bitwise
>> comparison for all inputs now?
>>
>
> That simplification makes sense, thank you for pointing it out.
>
> I've updated the code to use only bitwise comparisons. I've also updated
> the test so that it checks also if +-0 and +-Inf are folded.
>
> Here is the updated webrev: http://cr.openjdk.java.net/~
> zmajo/8073670/webrev.03/
>
> The new test works as expected with/without fix on all platforms supported
> by the hotspot_compiler_1 target in JPRT.
>
> Thank you and best regards,
>
>
> Zoltan
>
> P.S.: What is your OpenJDK ID, Vitaly? The OpenJDK conventions seem not to
> allow non-authors to appear in the "Reviewed-by" section of a patch:
>
> http://openjdk.java.net/guide/producingChangeset.html
>
>
>  Thanks
>>
>> sent from my phone
>>
>> On Feb 26, 2015 5:13 PM, "Zoltán Majó" <zoltan.majo at oracle.com <mailto:
>> zoltan.majo at oracle.com>> wrote:
>>
>>     Hi Vladimir,
>>
>>
>>     here is the final webrev that I intend to push:
>>
>>     http://cr.openjdk.java.net/~zmajo/8073670/webrev.02/
>>     <http://cr.openjdk.java.net/%7Ezmajo/8073670/webrev.02/>
>>
>>     Thank you and best regards,
>>
>>
>>     Zoltan
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20150227/97c07b06/attachment.html>