RFR(M): 8069035: compiler/oracle/CheckCompileCommandOption.java nightly failure

Albert Noll albert.noll at oracle.com
Fri Jan 16 09:27:07 UTC 2015


Hi Nils,

On 01/15/2015 08:23 PM, Nils Eliasson wrote:
> Hi,
>
> Please review this change. The push of JDK-8027829 caused a nightly 
> failure. The fix for allowing the signature to follow the method 
> without a whitespace wasn't complete and broke the option parsing.
>
> This change includes these fixes:
> * Fixing the removal of whitespace in option command parsing
> * Adding the test to TEST.groups (~7s test time on a fast machine)
That means the test will be run with every jprt push? In my view it is 
enough to run that test in nightlies.

Best,
Albert
> * Added additional test cases for the CompilerCommandFile
> * Added testcases for option parsing together with a method pattern 
> that includes a signature
> * Moved some testcases together that didn't require separate VMs
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8069035
> Webrev: http://cr.openjdk.java.net/~neliasso/8069035/webrev.01
>
> Best regards,
> Nils Eliasson
>



More information about the hotspot-compiler-dev mailing list