RFR(M): 8069035: compiler/oracle/CheckCompileCommandOption.java nightly failure

[Zoltán Majó]

Hi Nils,


On 01/21/2015 04:08 PM, Nils Eliasson wrote:
> Hi Zoltan,
>
> On 2015-01-16 15:34, Zoltán Majó wrote:
>>
>> I agree with Albert that it might be better to execute the 
>> test/compiler/oracle/CheckCompileCommandOption.java only in 
>> nightlies. Especially that the test might take much longer on the 
>> slower machines that we have.
>
> ok, I removed the test.
>
>>
>>> * Added additional test cases for the CompilerCommandFile
>>
>> That is a good idea, but I think you've forgotten to include those 
>> command files into the webrev. As a result, when I run the test with 
>> jtreg on my own machine, it fails with the following error message:
>
> Yes I did. Thanks for finding.
>
> I also added the added the bug number to the test attributes.
>
> Webrev: http://cr.openjdk.java.net/~neliasso/8069035/webrev.03/

This version looks good to me (not a Reviewer).

Thank you and best regards,


Zoltan

>
> Thanks for your help,
> Nils
>
>>
>> Thank you and best regards,
>>
>>
>> Zoltan
>>
>>> * Added testcases for option parsing together with a method pattern 
>>> that includes a signature
>>> * Moved some testcases together that didn't require separate VMs
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8069035
>>> Webrev: http://cr.openjdk.java.net/~neliasso/8069035/webrev.01
>>>
>>> Best regards,
>>> Nils Eliasson
>>>
>>
>