[9] RFR(S): 8130120: Handling of SHA intrinsics inconsistent across platforms
Zoltán Majó
zoltan.majo at oracle.com
Wed Jul 1 15:22:59 UTC 2015
Hi,
please review the patch for JDK-8130120.
Bug: https://bugs.openjdk.java.net/browse/JDK-8130120
Problem: Currently, the JVM prints different warning messages when
SHA-based intrinsics are attempted to be enabled (e.g., aarch64 prints
"SHA intrinsics are not available on this CPU" and x86 prints "SHA
instructions are not available on this CPU"). Also, there are flag
combinations that result in a warning on some platforms but not on other
platforms (e.g., -XX:-UseSHA -XX:+UseSHA1Intrinsics prints a warning on
x86 but it does not on aarch64 and on sparc).
Solution: Change the handling of the UseSHA, UseSHA1Intrinsics,
UseSHA256Intrinsics, and UseSHA512Intrinsics flags to work the same way
on x86, aarch64, and sparc. Change warning messages to be consistent
among the previously mentioned platforms and also to better match the
flag's description. Update the tests in test/compiler/intrinsics/sha to
match the new functionality.
Webrev: http://cr.openjdk.java.net/~zmajo/8130120/webrev.00/
Testing:
- full JPRT run (includes the updated tests that were executed on x86
and sparc), all tests pass;
- locally executed the test/compiler/intrinsics/sha tests on aarch64;
all tests pass.
Thank you and best regards,
Zoltan
More information about the hotspot-compiler-dev
mailing list