[9] RFR(S): 8130120: Handling of SHA intrinsics inconsistent across platforms

[Zoltán Majó]

Thank you, Vladimir!

Best regards,


Zoltan


On 07/02/2015 05:09 PM, Vladimir Kozlov wrote:
> Looks good.
>
> Thanks,
> Vladimir
>
> On 7/2/15 5:17 AM, Zoltán Majó wrote:
>> Thank you, Vladimir and Michael, for the feedback!
>>
>> Here is the updated webrev:
>> http://cr.openjdk.java.net/~zmajo/8130120/webrev.01/
>>
>> All JPRT tests pass.
>>
>> I plan to push the newest webrev (webrev.01) on Friday (July 3) if no 
>> other issues come up by then.
>>
>> Thank you and best regards,
>>
>>
>> Zoltan
>>
>>
>> On 07/02/2015 12:57 AM, Berg, Michael C wrote:
>>> Looks good, once Vladimir's note is added.
>>>
>>> Thanks,
>>> -Michael
>>>
>>> -----Original Message-----
>>> From: hotspot-compiler-dev 
>>> [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of 
>>> Vladimir Kozlov
>>> Sent: Wednesday, July 01, 2015 11:48 AM
>>> To: hotspot-compiler-dev at openjdk.java.net
>>> Subject: Re: [9] RFR(S): 8130120: Handling of SHA intrinsics 
>>> inconsistent across platforms
>>>
>>> Looks good but I would keep "on this CPU" at the end of messages to 
>>> clear indicate that it is due to instructions are
>>> not available.
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 7/1/15 8:22 AM, Zoltán Majó wrote:
>>>> Hi,
>>>>
>>>>
>>>> please review the patch for JDK-8130120.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8130120
>>>>
>>>> Problem: Currently, the JVM prints different warning messages when
>>>> SHA-based intrinsics are attempted to be enabled (e.g., aarch64 prints
>>>> "SHA intrinsics are not available on this CPU" and x86 prints "SHA
>>>> instructions are not available on this CPU"). Also, there are flag
>>>> combinations that result in a warning on some platforms but not on
>>>> other platforms (e.g., -XX:-UseSHA -XX:+UseSHA1Intrinsics prints a
>>>> warning on
>>>> x86 but it does not on aarch64 and on sparc).
>>>>
>>>> Solution: Change the handling of the UseSHA, UseSHA1Intrinsics,
>>>> UseSHA256Intrinsics, and UseSHA512Intrinsics flags to work the same
>>>> way on x86, aarch64, and sparc. Change warning messages to be
>>>> consistent among the previously mentioned platforms and also to better
>>>> match the flag's description. Update the tests in
>>>> test/compiler/intrinsics/sha to match the new functionality.
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~zmajo/8130120/webrev.00/
>>>>
>>>> Testing:
>>>> - full JPRT run (includes the updated tests that were executed on x86
>>>> and sparc), all tests pass;
>>>> - locally executed the test/compiler/intrinsics/sha tests on aarch64;
>>>> all tests pass.
>>>>
>>>> Thank you and best regards,
>>>>
>>>>
>>>> Zoltan
>>>>
>>