[aarch64-port-dev ] RFR: 8131362: aarch64: C2 does not handle large stack offsets

[Andrew Haley]

On 16/07/15 09:46, Edward Nevill wrote:
> Hi,
> 
> http://cr.openjdk.java.net/~enevill/8131362/webrev.01
> 
> Provides support for large spill offsets in C2 on aarch64.

Thanks.  This is a clear improvement over what we have now.

A few minor things.

~((1<<12)-1)  is just  -1<<12

I don't like the way that spill_address silently clobbers rscratch2
and callers of spill_address clobber rscratch1.  This makes me rather
nervous.  We have had recent bugs which were caused by macros assuming
they had exclusive use of scratch registers.  Please consider passing
a destination register down to spill_address and spill_copy128.  I
think if you do that the register usage will be much clearer to the
reader.

Andrew.