RFR: 8131483 : aarch64: illegal stlxr instructions

Andrew Haley aph at redhat.com
Thu Jul 16 13:58:58 UTC 2015


On 07/16/2015 02:52 PM, Edward Nevill wrote:
> On Thu, 2015-07-16 at 10:49 +0100, Andrew Haley wrote:
>> On 16/07/15 10:25, Edward Nevill wrote:
>>>
>>> Fixes an issue reported by one of our partners where the aarch64 port is generating illegal instructions on their HW.
>>>
>>> The instruction in question is
>>>
>>>  stlxr(rscratch1, end, rscratch1)
>>>
>>>
>>
>> Please assert this in Assembler::stlxr.
> 
> OK. New webrev @
> 
> http://cr.openjdk.java.net/~enevill/8131483/webrev.01

+    assert(Rs != Rn, "unpredicatable instruction");                  \

"unpredicatable"?  "unpredictable," surely?  :-)

The fix is ok with that spelling change.

Thanks,
Andrew.



More information about the hotspot-compiler-dev mailing list