RFR(XS): 8131676: Fix warning 'negative int converted to unsigned' after 8085932.

[Vladimir Kozlov]

Looks good. Thank you for fixing second issue. I will push it.

Vladimir

On 7/17/15 1:54 AM, Lindenmaier, Goetz wrote:
> Hi Vladimir,
>
> Thanks for the review!
>
> I can't reproduce the problem in vm_version_x86.hpp.  I tried on a row of
> 32 and 64 bit machines with different compilers ...
> I fixed it anyways:
> http://cr.openjdk.java.net/~goetz/webrevs/8131676-negUInt/webrev.02/
>
> Best regards,
>    Goetz
>
>
> -----Original Message-----
> From: Vladimir Kozlov [mailto:vladimir.kozlov at oracle.com]
> Sent: Donnerstag, 16. Juli 2015 20:35
> To: Lindenmaier, Goetz; 'hotspot-compiler-dev at openjdk.java.net compiler'
> Subject: Re: RFR(XS): 8131676: Fix warning 'negative int converted to unsigned' after 8085932.
>
> Hi Goetz,
>
> Looks good.
>
> Do you see also next problem?:
>
> hotspot/src/cpu/x86/vm/vm_version_x86.hpp:485: error: integer constant
> is too large for 'long' type
> hotspot/src/cpu/x86/vm/vm_version_x86.hpp:705: error: integer constant
> is too large for 'long' type
>
> Can you fix and test it too? Use CONST64:
>
> #define CPU_AVX512VL CONST64(0x100000000)
>
>
> On 7/16/15 5:25 AM, Lindenmaier, Goetz wrote:
>> Hi,
>>
>> A new warning kills the build with gcc 4.2.
>>
>> Could I please get a review and a sponsor for this tiny change?
>>
>> http://cr.openjdk.java.net/~goetz/webrevs/8131676-negUInt/webrev.01/
>>
>> Best regards,
>>
>>     Goetz.
>>