RFR: 8132010: aarch64: Typo in SHA intrinsics flags handling code for aarch64
Edward Nevill
edward.nevill at gmail.com
Tue Jul 21 09:18:35 UTC 2015
On Mon, 2015-07-20 at 14:38 +0000, Alexeev, Alexander wrote:
> Please review provided patch and sponsor if approved.
> Problem: SHA flags verification code checks condition for
> UseSHA256Intrinsics, but corrects UseSHA1Intrinsics.
> The patch:
> http://cr.openjdk.java.net/~aalexeev/1/webrev.00/
Hi Alexander,
Thanks for fixing this. I will sponsor this patch.
Here is the changeset.
http://cr.openjdk.java.net/~enevill/8132010/webrev
I have tested this before and after with hotspot jtreg
Before: Test results: passed: 876; failed: 3; error: 7
After: Test results: passed: 877; failed: 2; error: 7
The 1 test fixed is the test
compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnSupportedCPU.java
This regression was introduced in the following changeset
http://hg.openjdk.java.net/jdk9/dev/hotspot/rev/cd16fcb838d2
Could I have an official reviewer for this please. As this is a trivial
1 liner I think one reviewer should be sufficient.
All the best,
Ed.
More information about the hotspot-compiler-dev
mailing list