RFR: 8132010: aarch64: Typo in SHA intrinsics flags handling code for aarch64

[Lindenmaier, Goetz]

Hi Edward,

webrev.01 looks good. Reviewed.

Best regards,
  Goetz.

-----Original Message-----
From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of Edward Nevill
Sent: Dienstag, 21. Juli 2015 16:28
To: Alexeev, Alexander
Cc: hotspot compiler; aarch64-port-dev at openjdk.java.net
Subject: Re: RFR: 8132010: aarch64: Typo in SHA intrinsics flags handling code for aarch64

On Tue, 2015-07-21 at 10:18 +0100, Edward Nevill wrote:
> On Mon, 2015-07-20 at 14:38 +0000, Alexeev, Alexander wrote:
> 
> > Please review provided patch and sponsor if  approved.
> > Problem: SHA flags verification code checks condition for
> > UseSHA256Intrinsics, but corrects UseSHA1Intrinsics.
> > The patch:
> > http://cr.openjdk.java.net/~aalexeev/1/webrev.00/
> 
> Hi Alexander,
> 
> Thanks for fixing this. I will sponsor this patch.
> 
> Here is the changeset.
> 
> http://cr.openjdk.java.net/~enevill/8132010/webrev

Please disregard the above webrev. I had outstanding outgoing changes.

Here is the corrected changeset. It is just a single line change in vm_version_aarch64.cpp

http://cr.openjdk.java.net/~enevill/8132010/webrev.01

Sorry for the confusion, working on too many changesets at once.

Ed.

> 
> I have tested this before and after with hotspot jtreg
> 
> Before: Test results: passed: 876; failed: 3; error: 7
> After: Test results: passed: 877; failed: 2; error: 7
> 
> The 1 test fixed is the test
> 
> compiler/intrinsics/sha/cli/TestUseSHA256IntrinsicsOptionOnSupportedCPU.java
> 
> This regression was introduced in the following changeset
> 
> http://hg.openjdk.java.net/jdk9/dev/hotspot/rev/cd16fcb838d2 
> 
> Could I have an official reviewer for this please. As this is a trivial
> 1 liner I think one reviewer should be sufficient.
> 
> All the best,
> Ed.
> 
>