RFR(M): 8004073: Implement C2 Ideal node specific dump() method

[Michael Haupt]

Hi Vladimir,

thank you.

Anyone, please review ...

Best,

Michael

> Am 30.07.2015 um 04:15 schrieb Vladimir Kozlov <vladimir.kozlov at oracle.com>:
> 
> This looks good to me. You need secondreviewer to look on this since changes are big.
> 
> Thanks.
> Vladimir
> 
> On 7/29/15 1:54 AM, Michael Haupt wrote:
>> Hi Vladimir,
>> 
>> thank you for your comments. I have uploaded a revised webrev to
>> http://cr.openjdk.java.net/~mhaupt/8004073/webrev.01; some replies are
>> inlined below.
>> 
>>> Am 28.07.2015 um 19:24 schrieb Vladimir Kozlov
>>> <vladimir.kozlov at oracle.com <mailto:vladimir.kozlov at oracle.com>>:
>>> Before looking to webrev, can you use whole word Node::related(),
>>> dump_related(), dump_related_compact(), dump_compact()? "comp" could
>>> be confused for "compiled". It is more typing in debugger but it is
>>> more clear.
>> 
>> Done.
>> 
>>> Also from  this->dump_rel() in your example I see that you dump a lot
>>> more input nodes than I expect (only up to inputs of CmpU node).
>>> But this->dump_rel_comp() produces correct set of nodes.
>> 
>> The depth of output can be controlled with the method
>> Node::dump_related(int d_in, int d_out); in my initial post I had not
>> mentioned this method. The default output is also formatted in a way
>> that makes clear where the current node (>) is, and where all the inputs
>> (before) and outputs (after) are. Regarding the notion of "related
>> nodes", YMMV.
>> 
>> For additional illustration, I've added an implementation of related()
>> for PhiNode.
>> 
>>> It would be nice if you can avoid using macro:
>>> 
>>> +#ifndef PRODUCT
>>> +  REL_IN_DATA_OUT_1;
>>> +#endif
>>> 
>>> "Arithmetic nodes" are most common data nodes (vs control nodes
>>> this->is_CFG() == true). May be instead specialized rel() method you
>>> can use some flags checks in Node::rel() method.
>> 
>> Done.
>> 
>> Best,
>> 
>> Michael


-- 

 <http://www.oracle.com/>
Dr. Michael Haupt | Principal Member of Technical Staff
Phone: +49 331 200 7277 | Fax: +49 331 200 7561
Oracle Java Platform Group | LangTools Team | Nashorn
Oracle Deutschland B.V. & Co. KG, Schiffbauergasse 14 | 14467 Potsdam, Germany
 <http://www.oracle.com/commitment>	Oracle is committed to developing practices and products that help protect the environment

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20150730/2bbd5eeb/attachment.html>