[9] RFR (M): VM should constant fold Unsafe.get*() loads from final fields

[Paul Sandoz]

On Jun 18, 2015, at 2:12 PM, Remi Forax <forax at univ-mlv.fr> wrote:

> Hi Paul,
> 
> On 06/18/2015 02:03 PM, Paul Sandoz wrote:
>> Hi Vladimir,
>> 
>> I like the test, you have almost hand rolled your own specializer :-)
>> 
>> A minor point. Since you have created a ClassWriter with "ClassWriter.COMPUTE_MAXS | ClassWriter.COMPUTE_FRAMES" can you remove the "mv.visitMax(0, 0)" calls?
> 
> no, you can't.
> even if you ask ASM to compute the maxs, you still need to call visitMaxs() or kitten will die.
> 

Ah, i see now, it's the arguments to visitMax that are ignored and not the call itself.

Thanks,
Paul.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 841 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20150618/77142c1e/signature.asc>