RFR 8076276 support for AVX512
Vladimir Kozlov
vladimir.kozlov at oracle.com
Thu May 7 17:40:07 UTC 2015
Thanks, Roland
On 5/7/15 3:25 AM, Roland Westrelin wrote:
>> http://cr.openjdk.java.net/~kvn/8076276/webrev.02
>
> This looks good to me. A few minor remarks:
>
> Shouldn’t the #ifdef _LP64 new instruct be in x86_64.ad? I see there are already other #ifdef _LP64 in x86.ad so I’m not sure what the guideline is.
Why you need #ifdef _LP64 in x86_64.ad were _LP64 is set by default
(used only in 64-bit VM)? What new instructions you are talking about?
>
> In vm_version_x86.hpp, os_supports_avx_vectors(), you could have a single copy of the loop with different parameters.
>
> Not sure why you dropped:
>
> 3463 // Float register operands
> 3473 // Double register operands
>
> in x86_64.ad
>
> In chaitin.hpp:
>
> 144 uint16_t _num_regs; // 2 for Longs and Doubles, 1 for all else
>
> comment is not aligned with the one below anymore.
>
> Roland.
>
I also have questions to Michael.
Why you renamed chunk2 to "alloc_class chunk3(RFLAGS);"?
Why you moved "operand vecS() etc." from x86.ad ? Do you mean evex is
not supported in 32-bit?
Thanks,
Vladimir
More information about the hotspot-compiler-dev
mailing list