RFR(XS): 8080828: Create sanity test for JDK-8080155

Staffan Larsen staffan.larsen at oracle.com
Thu May 21 11:04:10 UTC 2015


Looks good!

Thanks,
/Staffan

> On 21 maj 2015, at 12:55, Yekaterina Kantserova <yekaterina.kantserova at oracle.com> wrote:
> 
> The new webrev can be found here: http://cr.openjdk.java.net/~ykantser/8080828/webrev.01
> 
> Thanks,
> Katja
> 
> 
> 
> On 05/21/2015 10:15 AM, Staffan Larsen wrote:
>> I just realize that you also need to add a check if SA can attach on the current platform. See the test in sa/jmap-hashcode:
>> 
>> if (!Platform.shouldSAAttach()) {
>>     System.out.println("SA attach not expected to work - test skipped.");
>>     return;
>> }
>> 
>> Thanks,
>> /Staffan
>> 
>>> On 21 maj 2015, at 10:13, Staffan Larsen <staffan.larsen at oracle.com> wrote:
>>> 
>>> Can we add some kind of validation of the output? Something simple, just to verify that we actually ran what we think we ran.
>>> 
>>>> On 21 maj 2015, at 09:33, Yekaterina Kantserova <yekaterina.kantserova at oracle.com> wrote:
>>>> 
>>>> Hi,
>>>> 
>>>> Could I please have a review of this new test.
>>>> 
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8080828
>>>> webrev: http://cr.openjdk.java.net/~ykantser/8080828/webrev.00
>>>> 
>>>> This test will trigger the exception reported in https://bugs.openjdk.java.net/browse/JDK-8080155 if running with -Xcomp.
>>>> 
>>>> Thanks,
>>>> Katja
> 



More information about the hotspot-compiler-dev mailing list