RFR (S) 8141044: C1 should fold (this == null) to false

Aleksey Shipilev aleksey.shipilev at oracle.com
Tue Nov 3 22:46:57 UTC 2015


On 11/04/2015 01:40 AM, John Rose wrote:
> On Nov 3, 2015, at 1:42 PM, Aleksey Shipilev
> <aleksey.shipilev at oracle.com <mailto:aleksey.shipilev at oracle.com>> wrote:
>>
>> Actually, scratch that, I've played with different examples, including
>> the A*FU case, and the example Kris shows above, and we elide the
>> null-check in all interesting cases. Therefore, I'd like the current
>> patch to go in its current form. For the record:
>>  http://cr.openjdk.java.net/~shade/8141044/webrev.01/
>> <http://cr.openjdk.java.net/%7Eshade/8141044/webrev.01/>
> 
> Reviewed.  Nice work.
> 
> I'm glad you are not changing the type system.  That's a high-leverage,
> high-risk move.

Thanks John!

Having no other comments in 24 hours, and once/if RBT results come
clean, I'll push.

Cheers,
-Aleksey


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151104/fa584aa8/signature.asc>


More information about the hotspot-compiler-dev mailing list