[9] RFR(S): 8141443: jdk/test/java/util/regex/RegExTest.java fails: No match found

Tobias Hartmann tobias.hartmann at oracle.com
Thu Nov 5 12:51:52 UTC 2015


Hi Aleksey,

thanks for the review.

On 05.11.2015 13:42, Aleksey Shipilev wrote:
> On 11/05/2015 03:14 PM, Tobias Hartmann wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8141443 
>> http://cr.openjdk.java.net/~thartmann/8141443/webrev.00/
> 
> Looks good.
> 
> Am I correct in thinking that a similar-looking access a few lines above
> is not problematic, since we are storing back to T_BYTE?
> 
> 1508       Node* val = __ ConI(src_array->byte_at(i));
> 1509       __ store(__ ctrl(), adr, val, T_BYTE, byte_adr_idx,
> MemNode::unordered);

Yes, exactly. We can save the '& 0xff' here.

Best,
Tobias


More information about the hotspot-compiler-dev mailing list