RFR: 8138689 use package for /compiler/whitebox common classes

[Dmitrij Pochepko]

Thank you!
> Good.
> — Igor
>> On Nov 5, 2015, at 4:24 PM, Dmitrij Pochepko <dmitrij.pochepko at oracle.com> wrote:
>>
>> Hi,
>>
>> please, take a look at 2nd version: http://cr.openjdk.java.net/~dpochepk/8138689/webrev.02/
>> Changes: i've moved SimpleTestCase to separate file and removed mentioned code in LevelTransitionTest
>>
>> Thanks,
>> Dmitrij
>>> Hi Dmitrij,
>>>
>>> the patch looks good for me except one place:
>>>
>>> http://cr.openjdk.java.net/~dpochepk/8138689/webrev.01/test/compiler/tiered/LevelTransitionTest.java.udiff.html
>>>>           return testCase == ExtendedTestCase.ACCESSOR_TEST
>>>> -                || testCase == SimpleTestCase.METHOD_TEST
>>>> -                || testCase == SimpleTestCase.STATIC_TEST
>>>> +                || testCase.name().equals("METHOD_TEST")
>>>> +                || testCase.name().equals("STATIC_TEST”)
>>> I think it’ll be better to make compiler.whitebox.SimpleTestCase public available class, then you won’t have that nasty changes in LevelTransitionTest.
>>>
>>> Thanks,
>>> — Igor
>>>
>>>> On Nov 4, 2015, at 12:41 AM, dmitrij pochepko <dmitrij.pochepko at oracle.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> a link to webrev: http://cr.openjdk.java.net/~dpochepk/8138689/webrev.01/
>>>>
>>>> Thanks,
>>>> Dmitrij
>>>>> Hi,
>>>>>
>>>>> please review fix for https://bugs.openjdk.java.net/browse/JDK-8138689 - use package for /compiler/whitebox common classes
>>>>>
>>>>> Description:
>>>>>
>>>>> A common class CompilerWhiteBoxTest was moved to compiler.whitebox package, so, respective changes were made in tests to reflect that.
>>>>> Also, a CompilerWhiteBoxTest has few protected static fields and methods moved to public for tests to access it.
>>>>>
>>>>> Test changes: most of tests has 2 changes:
>>>>> a) changed @library tag entry from '/compiler/whitebox' to '/'
>>>>> b) added import compiler.whitebox.CompilerWhiteBoxTest;
>>>>>
>>>>> also compiler/whitebox tests which has CompilerCommand compileonly directive were changed to have package name in compileonly parameter.
>>>>> another small change is in LevelTransitionTest isTrivial() detection which can't access SimpleTestCase, so, testcase filtering is done by testcase name now.
>>>>>
>>>>> Testing: I've tested it on linux-amd64
>>>>>
>>>>> Thanks,
>>>>> Dmitrij