RFR(XS): 8141552 [TESTBUG] compiler/jvmci/events/JvmciNotifyInstallEventTest failed after jvmci refresh

Dmitrij Pochepko dmitrij.pochepko at oracle.com
Fri Nov 6 10:33:25 UTC 2015


Thank you!
>
>> On Nov 5, 2015, at 7:32 AM, Dmitrij Pochepko 
>> <dmitrij.pochepko at oracle.com <mailto:dmitrij.pochepko at oracle.com>> wrote:
>>
>> Hi,
>>
>> please review fix for:
>> https://bugs.openjdk.java.net/browse/JDK-8141552 - [TESTBUG] 
>> compiler/jvmci/events/JvmciNotifyInstallEventTest failed after jvmci 
>> refresh
>>
>> A problem was that test tried to install same CompilationResult code 
>> twice, which is not allowed because 
>> HotSpotCodeCacheProvider.installCode method sets finalizeLayout state 
>> for DataSection inside CompilationResult and this state can't be set 
>> twice for same instance(there is an assertion verifying that). So, as 
>> a fix, i've added creation and initialization of another instance to 
>> have a new instance with fresh state.
>>
>> webrev: http://cr.openjdk.java.net/~dpochepk/8141552/webrev.01/ 
>> <http://cr.openjdk.java.net/%7Edpochepk/8141552/webrev.01/>
>
> Looks good.
>
>>
>> I've tested it on linux-amd64.
>>
>> Thanks,
>> Dmitrij
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151106/d060a452/attachment-0001.html>


More information about the hotspot-compiler-dev mailing list