RFR(S): 8142329: [JVMCI] pass Handle by value

Carsten Varming varming at gmail.com
Mon Nov 9 17:07:48 UTC 2015


Dear Roland,

Coleen recently changes a bunch of handle values to references (see
http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/6ab7e19c9220,
https://bugs.openjdk.java.net/browse/JDK-8140274). Perhaps the comment in
handles.hpp should be updated to reflect the efficiency goal of Coleen's
recent change. Your change has both constantPoolHandles and methodHandles,
so it would be nice to not go backwards.

Carsten

On Mon, Nov 9, 2015 at 11:36 AM, Roland Schatz <roland.schatz at oracle.com>
wrote:

> Hi,
>
> In JVMCI we have a few methods using `Handle&` as argument, according to
> the comment in handle.hpp this should be `Handle` directly.
>
> JIRA:
> https://bugs.openjdk.java.net/browse/JDK-8142329
>
> Webrev:
> http://cr.openjdk.java.net/~rschatz/JDK-8142329/webrev.00/
>
> Please review.
>
> Thanks,
> Roland
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151109/595f0ddc/attachment.html>


More information about the hotspot-compiler-dev mailing list