[9] RFR(XS): 8138810: rework tests for CompilerToVM::allocateCompiledId

Christian Thalinger christian.thalinger at oracle.com
Tue Nov 10 20:42:20 UTC 2015


+            Asserts.assertTrue(ids.add(wbCompileID), testCase
+                    + " : vm compilation allocated existed id " + id);
+            Asserts.assertTrue(ids.add(id), testCase
+                    + " : allocateCompileId returned existed id " + id);

I think these should say “existing id”.  Otherwise this looks good.

> On Nov 10, 2015, at 8:26 AM, Tatiana Pivovarova <tatiana.pivovarova at oracle.com> wrote:
> 
> Hy guys!
> 
> Please review this small patch
> I just added loop to check that the allocation allocate new id on each iteration and used length of bytecode to define incorrect bci.
> 
> Test:
>   jtreg
> 
> webrev: http://cr.openjdk.java.net/~tpivovarova/8138810/webrev.00/ <http://cr.openjdk.java.net/~tpivovarova/8138810/webrev.00/>
> bugid: https://bugs.openjdk.java.net/browse/JDK-8138810 <https://bugs.openjdk.java.net/browse/JDK-8138810>
> 
> Thanks,
> Tatiana

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151110/e8a1bcf5/attachment.html>


More information about the hotspot-compiler-dev mailing list