RFR(S): 8042997: Make intrinsic some or all check index/range methods

Roland Westrelin roland.westrelin at oracle.com
Mon Nov 16 09:23:05 UTC 2015


Thanks for the reviews Aleksey, Paul and Vladimir.

I removed the InlineObjectsCheckIndex flag and turned the jdk comment into an @implNote.

Roland.


> On Nov 9, 2015, at 1:19 PM, Vladimir Ivanov <vladimir.x.ivanov at oracle.com> wrote:
> 
> Hotspot part looks good.
> 
> I second Aleksey's suggestion to get rid of InlineObjectsCheckIndex flag.
> 
> Best regards,
> Vladimir Ivanov
> 
> On 11/9/15 2:24 PM, Roland Westrelin wrote:
>> http://cr.openjdk.java.net/~roland/8042997/webrev.00/
>> http://cr.openjdk.java.net/~roland/8042997.jdk/webrev.00/
>> 
>> This intrinsifies Objects.checkIndex() as a CmpU + RangeCheck node sequence that C2 then optimizes using the existing range check optimizations. The goal is allow library code to have range checks that are guaranteed to be properly optimized.
>> 
>> I’m not sure if we want to leave the comment on c2 in the library code.
>> 
>> Roland.
>> 



More information about the hotspot-compiler-dev mailing list