RFR(M) 8138892: C1: Improve counter overflow checking

[Doerr, Martin]

Hi Christian,

is this still on your todo list?

Best regards,
  Martin

From: Christian Thalinger [mailto:christian.thalinger at oracle.com]
Sent: Mittwoch, 21. Oktober 2015 01:58
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Cc: Doerr, Martin <martin.doerr at sap.com>; hotspot compiler <hotspot-compiler-dev at openjdk.java.net>; Andrew Haley (aph at redhat.com) <aph at redhat.com>
Subject: Re: RFR(M) 8138892: C1: Improve counter overflow checking

Sorry, I’m pretty busy but I will try to sponsor this.

On Oct 11, 2015, at 10:58 PM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>> wrote:

Hi Martin,

this change looks good, thank you.

Could someone please sponsor this?

Best regards,
  Goetz.

From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces at openjdk.java.net]On Behalf Of Doerr, Martin
Sent: Mittwoch, 7. Oktober 2015 23:02
To: hotspot compiler; Andrew Haley (aph at redhat.com<mailto:aph at redhat.com>)
Subject: RFR(M) 8138892: C1: Improve counter overflow checking

Hi,

C1 currently loads the Method pointer in the fast path even though it is only required in the overflow case. In addition, stupid code gets generated when the frequency is set to 0 which occurs with -Xcomp.

The following webrev optimizes that:
http://cr.openjdk.java.net/~mdoerr/8138892_c1_counter_overflow/webrev.02

It’s not tested on aarch64.

Please review this change.  I need a sponsor, please.

Best regards,
  Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151117/a107b86b/attachment-0001.html>