RFR: 8087223: InterfaceMethod CP entry pointing to a class should cause ICCE
Yumin Qi
yumin.qi at oracle.com
Tue Nov 17 22:05:30 UTC 2015
Thanks for the review!
Yumin
On 11/17/2015 1:13 PM, Vladimir Ivanov wrote:
> Looks good!
>
> Thanks for covering method handle case.
>
> Best regards,
> Vladimir Ivanov
>
> On 11/17/15 6:51 PM, Yumin Qi wrote:
>> Hi, Vladimir and all
>>
>> New webrev at:
>> http://cr.openjdk.java.net/~minqi/8087223/webrev-02/
>>
>> In this version, changes made to
>> ConstantPool::resolve_constant_at_impl (which you mentioned in offline
>> email for resolution process for methodHandle) to check if the method
>> handle resolution to method with a correct constant tag, which solved
>> the method handle resolution to throw ICCE correctly.
>> Also added one more test case for method handle resolution based on
>> the jasm version in the bug.
>>
>> Tests: JPRT, runtime quick list, jdk/test/java/lang/invoke
>>
>>
>> Thanks
>> Yumin
>>
>> On 11/13/2015 10:50 AM, Vladimir Ivanov wrote:
>>> Looks good.
>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8087223
>>>> webrev:
>>>> http://javaweb.us.oracle.com/~yqi/webrev/webrevs/8087223/8087223/webrev-01/
>>>>
>>>>
>>>
>>>> The fix solved the problem when call is from interpreter and compiler,
>>>> bug for MethodHandle invoke, which should be addressed in another bug,
>>>> since the MethodHandle does not come with a byte stream and getting
>>>> the
>>>> constant pool index at the invoke is not possible. It will be
>>>> addressed
>>>> in another bug.
>>> Is there a bug filed for that?
>>>
>>> Best regards,
>>> Vladimir Ivanov
>>
More information about the hotspot-compiler-dev
mailing list