RFR(M): 8134579: [TESTBUG] Some bmi tests fail if can_access_local_variables is on.

[Lindenmaier, Goetz]

Hi Vladimir, 

Thanks for looking at this!  This is quite old, great it's picked up ;)

I editied the @run command as you asked.  I also updated the paths, 
as it was done in the deleted files.  I rebased the change.
Here's a new webrev:
http://cr.openjdk.java.net/~goetz/webrevs/8134579-bmi/webrev.01

Best regards,
  Goetz.

-----Original Message-----
From: Vladimir Ivanov [mailto:vladimir.x.ivanov at oracle.com] 
Sent: Tuesday, November 17, 2015 12:14 PM
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot compiler <hotspot-compiler-dev at openjdk.java.net>
Subject: Re: RFR(M): 8134579: [TESTBUG] Some bmi tests fail if can_access_local_variables is on.

Goetz, looks good!

Small suggestion: can you use "@run main/bootclasspath" instead of "@run 
main/othervm -Xbootclasspath/a:." in newly introduced tests?

Best regards,
Vladimir Ivanov

On 9/28/15 2:54 PM, Lindenmaier, Goetz wrote:
> Could someone please have a look at this?
>
> Thanks and best regards,
>
>    Goetz.
>
> *From:*Lindenmaier, Goetz
> *Sent:* Montag, 21. September 2015 12:45
> *To:* hotspot compiler
> *Subject:* RFR(M): 8134579: [TESTBUG] Some bmi tests fail if
> can_access_local_variables is on.
>
> Hi,
>
> I saw two problems in the *intrinsics/bmi/verifycode* tests in our
> nightly runs.
>
> Unfortunately they did not reproduce easily.
>
> With can_access_local_variables() switched on the pattern matched in
> AddnTestI/L
>
> is messed up with an edge to the Uncommon trap for the NPE.
>
> T/LzcntTestI/L were compiled with an uncommon trap before the call to the
>
> Interger method.
>
> This easily can be fixed by checking for NULL and calling the test
> function once
>
> Before compiling the method.
>
> I also fixed the name of AddnTestI/L.  They actually call TestAndnI/L
> internally
>
> and thus should be named AndnTestI/L.
>
> Please review this change.  I please need a sponsor.
>
> http://cr.openjdk.java.net/~goetz/webrevs/8134579-bmi/webrev.00/
>
> Best regards,
>
>    Goetz Lindenmaier
>