RFR (M): 8143353: Update for x86 sin and cos in the math lib

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Nov 23 18:36:55 UTC 2015


On 11/20/15 12:22 PM, Vladimir Kozlov wrote:
> What is the reason you decided to add new flags? exp() and log() changes
> did not have flags.
>
> It would be interesting to see what happens if you disable intrinsics
> using existing flag, for example:
>
>   -XX:+UnlockDiagnosticVMOptions -XX:DisableIntrinsic=_dexp

Hi Vivek,

I want to point that you can do this experiment later. We can file bugs 
and fixed them after FC.

For now, please, answer my question about flags only. This is the only 
thing holding it from push.

Thanks,
Vladimir

>
> Thanks,
> Vladimir
>
> On 11/20/15 12:03 PM, Deshpande, Vivek R wrote:
>> Hi all
>>
>> I would like to contribute a patch which optimizes Math.sin() and
>> Math.cos() for 64 and 32 bit X86 architecture using Intel LIBM
>>   implementation.
>>
>> The improvement gives ~4.25x gain over base for both sin and cos.
>>
>> The option to use the optimizations are -XX:+UseLibmSinIntrinsic and
>> -XX:+UseLibmCosIntrinsic.
>>
>> Could you please review and sponsor this patch.
>>
>> Bug-id:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8143353
>> webrev:
>>
>> http://cr.openjdk.java.net/~mcberg/8143353/webrev.01/
>>
>> Thanks and regards,
>>
>> Vivek
>>


More information about the hotspot-compiler-dev mailing list