RFR(S): 8139384 - [TESTBUG] JVMCI test fails with java.lang.RuntimeException: a 100_000 times invoked method should be mature

Dmitrij Pochepko dmitrij.pochepko at oracle.com
Mon Nov 23 22:51:53 UTC 2015


a link to v02:
http://cr.openjdk.java.net/~dpochepk/8139384/webrev.02/
>
>> On Nov 23, 2015, at 12:36 PM, Dmitrij Pochepko 
>> <dmitrij.pochepko at oracle.com <mailto:dmitrij.pochepko at oracle.com>> wrote:
>>
>> Hi,
>>
>> please review fix for 
>> https://bugs.openjdk.java.net/browse/JDK-8139384 - [TESTBUG] JVMCI 
>> test fails with java.lang.RuntimeException: a 100_000 times invoked 
>> method should be mature
>>
>> A test test/compiler/jvmci/compilerToVM/IsMatureTest.java failed 
>> using -Xcomp -XX:-TieredCompilation.
>> A reason was that isMature was false for these flags combination (a 
>> respective logic in NonTieredCompPolicy::is_mature).
>>
>> Test was changed to have Xcomp and TieredCompilation flags tracked 
>> and isMature state checked with respect to these options value.
>> Additionally, test was modified to use CompilerWhiteBoxTest.THRESHOLD 
>> constant to be unified with other tests.
>>
>> Webrev: http://cr.openjdk.java.net/~dpochepk/8139384/webrev.01/ 
>> <http://cr.openjdk.java.net/%7Edpochepk/8139384/webrev.01/>
>
> I don’t particularly like this check:
>
> +    private static final boolean IS_XCOMP
> +            = System.getProperty("java.vm.info 
> <http://java.vm.info>").contains("compiled”);
>
> but it’s alright.  To be a little more robust check for “compiled mode”.
>
>>
>>
>> Thanks,
>> Dmitrij
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151124/131e8b8f/attachment-0001.html>


More information about the hotspot-compiler-dev mailing list