RFR(M): 8066156: JEP-JDK-8046155: Test task: stress by dcmd

Igor Ignatyev igor.ignatyev at oracle.com
Tue Nov 24 17:35:26 UTC 2015


Hi Pavel.

looks good to me.

Thanks,
— Igor
> On Nov 24, 2015, at 4:21 PM, Pavel Punegov <pavel.punegov at oracle.com> wrote:
> 
> Thank you for reviews, Nils.
> 
> I ran this on my laptop with Xcomp and it seems fine. TimeLimitedRunner class used for this test executes it only for the specified time that less than timeout set in the jtreg header. 
> 
> — Thanks,
> Pavel Punegov
> 
>> On 24 Nov 2015, at 14:14, Nils Eliasson <nils.eliasson at oracle.com> wrote:
>> 
>> Hi Pavel,
>> 
>> I like the stress test. Have you tested that it works fine with -Xcomp? (That the running time doesn't get out of hand.)
>> 
>> Otherwise - looks good.
>> 
>> Regards,
>> Nils
>> 
>> On 2015-11-19 08:28, Pavel Punegov wrote:
>>> Please review these new stress tests for CompilerControl. Tests are aimed to stress directive adding with diagnostic command (dcmd).
>>> 
>>> StressAddMultiThreadedTest tries to connect to the testVM with multiple instances of icmd running in parallel.
>>> StressAddSequentiallyTest adds directive sequentially while it has enough time to do that.
>>> There are also changes made in the framework code. Executor became a separate class, extracted from Scenario. Test VM could be executed without performing method checks.
>>> 
>>> webrev: http://cr.openjdk.java.net/~ppunegov/8066156/webrev.00/
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8066156
>>> 
>>> — Thanks,
>>> Pavel Punegov
>>> 
>> 
> 



More information about the hotspot-compiler-dev mailing list