RFR(M) :8138993: JEP-JDK-8046155: Test task: add check for Compiler.directives_print diagnostic command

Igor Ignatyev igor.ignatyev at oracle.com
Tue Nov 24 17:41:37 UTC 2015


Pavel,

the change seems good to me, thanks.

— Igor
> On Nov 24, 2015, at 1:50 PM, Nils Eliasson <nils.eliasson at oracle.com> wrote:
> 
> Hi Pavel,
> 
> The test looks good.
> 
> Regards,
> Nils
> (Not a reviewer)
> 
> On 2015-11-20 19:13, Pavel Punegov wrote:
>> Hi,
>> 
>> please review the following change that makes CompilerControl tests check directives_print diagnostic command.
>> 
>> - Test framework got output processing for jcmd  processes that were executed during the test. 
>> - DirectiveBuilder and JcmdStateBuilder return a list of match directives that should be checked in output. 
>> - Executor handles multiple outputs from all of executed processes (main test VM and jcmds).
>> - New PrintDirectivesProcessor compares actual output with 
>> - Changed /../../test/lib to /test/lib to reflect recent changes in test.root
>> 
>> 
>> webrev: http://cr.openjdk.java.net/~ppunegov/8138993/webrev.00/
>> bug:  https://bugs.openjdk.java.net/browse/JDK-8138993
>> 
>> — Thanks,
>> Pavel Punegov
>> 
> 



More information about the hotspot-compiler-dev mailing list