RFR(XXL): 8144019: PPC64 C1: Introduce Client Compiler

[Lindenmaier, Goetz]

Hi Martin,

> I think load_const32 should be defined near
Oh, I see, there are other of that kind.

looks good now, thanks.

Best regards,
Goetz.


From: Doerr, Martin
Sent: Donnerstag, 26. November 2015 12:24
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-compiler-dev at openjdk.java.net
Subject: RE: RFR(XXL): 8144019: PPC64 C1: Introduce Client Compiler

Hi Götz,

thank you very much for the review.
Here my comments on your 3 points which I marked below:

1. I think load_const32 should be defined near the other load_const functions. Otherwise it will be hard to find. All of them could be moved into MacroAssembler, but I think such kind of cleanup goes beyond the scope of this change. Do you agree?

2.+3. Done.

In addition, I've updated c1_Runtime1_ppc.cpp for "8143014: Access PtrQueue member offsets through derived classes" .

The new webrev is here:
http://cr.openjdk.java.net/~mdoerr/8144019_ppc64_c1/webrev.01

Best regards,
  Martin

From: Lindenmaier, Goetz
Sent: Donnerstag, 26. November 2015 10:34
To: Doerr, Martin <martin.doerr at sap.com<mailto:martin.doerr at sap.com>>; hotspot-compiler-dev at openjdk.java.net<mailto:hotspot-compiler-dev at openjdk.java.net>
Subject: RE: RFR(XXL): 8144019: PPC64 C1: Introduce Client Compiler

Hi Martin,

thanks for doing this change, and especially for doing all
the implementation of the C1 port!

I only have a few comments:

1.
assembler_ppc.inline.hpp:981
load_const32() should be defined in macroAssembler_ppc.hpp, not in
assembler_ppc.hpp. (Especially after you added the comment in
assembler_ppc.hpp:195.)

2.
c1_CodeStubs_ppc.cpp:349
c1_CodeStubs_ppc.cpp:409
c1_LIRAssembler_ppc.cpp:182
I does not make sense to use flag CommentedAssembly and #ifndef PRODUCT here.
Block_comment() is stubbed out in product builds. CommentedAssembly is constant false
in opt builds.  Why would you want to switch it off in debug builds?
I think this is meant to protect additional code as in
macroAssembler_sparc.cpp:1298, "snprintf(buffer, sizeof(buffer), "verify_oop at %d", offset());"
so that it's optimized out in product builds.

3.
File c1_FpuStackSim_ppc.cpp is not needed, it's empty.
Please delete it.

Best regards,
  Goetz.

From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of Doerr, Martin
Sent: Mittwoch, 25. November 2015 15:06
To: hotspot-compiler-dev at openjdk.java.net<mailto:hotspot-compiler-dev at openjdk.java.net>
Subject: RFR(XXL): 8144019: PPC64 C1: Introduce Client Compiler

Hi,

we would like to contribute our PPC64 port of the Client Compiler to support Tiered Compilation.
The change includes refactoring of some functionality which is shared between C1 and C2 and some updates.

The webrev is here:
http://cr.openjdk.java.net/~mdoerr/8144019_ppc64_c1/webrev.00

It only changes PPC64 files, with one minor exception: make/linux/Makefile

Please review. I will also need a sponsor, please.

Best regards,
  Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151126/2dbcf2e3/attachment-0001.html>