RFR : 8043467 : JEP 233: Generate Run-Time Compiler Tests Automatically

[Igor Veresov]

> On Nov 26, 2015, at 9:35 AM, Volker Simonis <volker.simonis at gmail.com> wrote:
> 
> Hi Tatiana,
> 
> really a very impressive piece of work!
> 
> Even more impressive how Igor an Vladimir could review this within a few hours (I always new you're wizards, guys :)

That’s because I wrote the initial version of it ten years ago. Although it is substantially refactored and extended with some new functionality now, I have a feel of the context. :)

> 
> But more seriously: the code doesn't seem to contain any documentation at all and only a very homeopathic amount of comments. Would it be possible to add at least some kind of high-level documentation? Otherwise I think it will be very to grasp what's going on and/or maintain/extend this library for people not already involved in the project.
> 

That wouldn’t hurt. There is this high-level description: http://cr.openjdk.java.net/~iveresov/SUN060582-505001.pdf

> It would also be interesting to know if there's any bug you've already found until now with these tests. If yes, which one and if no, why do you expect to find bugs in the future?

There were a bunch of problems in C2 that it found back in the days.

igor

> 
> Finally, the JEP mentions the generation of tests with bytcode sequences not generated by Javac to stress the VM with legal but uncommon bytecode patterns. I think this is a very good idea, but at a first glance I couldn't see any bytcode generation (at least not with jdk.internal.org.objectweb.asm). Will this feature be implemented later?
> 
> Thanks,
> Volker
> 
> 
> On Wed, Nov 25, 2015 at 12:42 AM, Tatiana Pivovarova <tatiana.pivovarova at oracle.com <mailto:tatiana.pivovarova at oracle.com>> wrote:
> Hi!
> 
> Could you please review the code changes for JEP 233: Generate Run-Time Compiler Tests Automatically?
> 
> The intent of this project is to develop a tool (JIT-tester) which randomly generates syntactically and semantically correct code and verifies that the results from interpreter is the same the results from compiler. Please find more details in the JEP.
> 
> JEP : https://bugs.openjdk.java.net/browse/JDK-8043467 <https://bugs.openjdk.java.net/browse/JDK-8043467>
> webrev: http://cr.openjdk.java.net/~iignatyev/tpivovarova/jep-233/webrev.00/ <http://cr.openjdk.java.net/~iignatyev/tpivovarova/jep-233/webrev.00/>
> 
> Thanks, 
> Tatiana
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151126/60cdb450/attachment-0001.html>