RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

Alan Bateman Alan.Bateman at oracle.com
Sun Nov 29 16:08:04 UTC 2015


On 27/11/2015 09:06, Paul Sandoz wrote:
> :
>
>> Also wondering how these tests will access jdk.internal once we're using the modular image?
>>
> I believe it is sufficient to include:
>
>    28  * @modules java.base/jdk.internal.misc
>
> or:
>
>    28  * @modules java.base/sun.misc
>
>
> We will need to update all tests depending on sun.misc.Unsafe when it moves to a separate module.
>
> Paul.
The changes look okay to me too. If Spp were more widely used when we 
might choose an option other than -nel but what you have is fine.

On @modules then it would be good to add to get @modules 
java.base/jdk.internal.misc on any tests using the rehoused Unsafe. That 
makes it easier the jake forest is sync'ed up. If there are tests using 
sun.misc.Unsafe then @modules isn't needed. If there are tests with 
@modules java.base/sun.misc then we'll do a bulk update once the 
separation is complete.

-Alan


More information about the hotspot-compiler-dev mailing list