RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables

[Christian Tornqvist]

Hi Paul,


>> Tests .... don't think we use testng with any hotspot tests so not sure about that part.
>
>There are already quite a few, primarily in the serviceability area, search for “testng”.

We don't use testng for our runtime tests, please change these into normal jtreg tests.

Thanks,
Christian

-----Original Message-----
From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of Paul Sandoz
Sent: Friday, November 27, 2015 4:06 AM
Cc: hotspot compiler <hotspot-compiler-dev at openjdk.java.net>; Java Core Libs <core-libs-dev at openjdk.java.net>
Subject: Re: RFR 8143628: Fork sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables


> On 27 Nov 2015, at 01:59, David Holmes <david.holmes at oracle.com> wrote:
> 
> Hi Paul,
> 
> On 26/11/2015 7:55 PM, Paul Sandoz wrote:
>> Hi,
>> 
>> This is a request for an optimistic review to fork the sun.misc.Unsafe and jdk.internal.misc.Unsafe native method tables so that we can evolve the latter e.g. for VarHandles unsafe work
>> 
>>   http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-jdk/
>>   http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8143628-unsafe-native-hotspot/
> 
> Code changes seem fine.
> 

Thanks.


> Tests .... don't think we use testng with any hotspot tests so not sure about that part.

There are already quite a few, primarily in the serviceability area, search for “testng”.


> Also wondering how these tests will access jdk.internal once we're using the modular image?
> 

I believe it is sufficient to include:

  28  * @modules java.base/jdk.internal.misc

or:

  28  * @modules java.base/sun.misc


We will need to update all tests depending on sun.misc.Unsafe when it moves to a separate module.

Paul.