RFR(L): JEP165: Compiler Control

[Nils Eliasson]

Hi Roland,

On 2015-09-28 12:02, Roland Westrelin wrote:
> Hi Nils,
>
>> http://cr.openjdk.java.net/~neliasso/8046155/webrev.03/
> What does CompileCommandCompatibility do?

Control backwards compatibility with CompileCommand for testing 
purposes. I 'll change the name to the moee descriptive 
CompilerDirectivesIgnoreCompileCommands (default false).
>
> vm_operations.cpp
>
> Is that extra include really needed?
No, removed.
>
> CompilerQueueTest.java
>
> Is that extra import really needed?
No, removed.

>
> block.hpp
>
> You don’t need that ciEnv here, right?
No, left over from when the directives was stored in the viEnv.
>
> compileBroker.cpp
>
> 1717   should_break = dirset->BreakAtExecuteOption || task->check_break_at_flags();
>
> doesn’t seem to be used
>
> Except for those minor issues, looks good to me.
Fixed.
>
>
>> - Won't build c1 only or shark only.
> You can’t push if c1 only doesn’t build, right?

It was just a temporary glitch that is fixed now.

Thanks,
Nils
>
> Roland.