[9] RFR(M): 8078554: Compiler: implement ranges (optionally constraints) for those flags that have them missing

[Roland Westrelin]

Hi Zoltan,

> Webrev: http://cr.openjdk.java.net/~zmajo/8078554/

c2_globals.hpp

That one is not correct:
 461   product(intx, MaxNodeLimit, 80000,                                        \
 462           "Maximum number of nodes")                                        \
 463           range(1000, 80000)                                                \

I think the upper bound should be max_juint

 699   product(intx, LiveNodeCountInliningCutoff, 40000,                         \
 700           "max number of live nodes in a method")                           \
 701           range(0, max_juint / 8)                                           \

Out of curiosity why max_juint / 8 (not that it makes much of a difference)?

arguments.cpp

1099       Tier3InvokeNotifyFreqLog = 1;
1100       Tier4InvocationThreshold = 1;

Why that change?

globals.hp

2870   product_pd(uintx, TypeProfileLevel,                                       \
2871           "=XYZ, with Z: Type profiling of arguments at call; "             \
2872                      "Y: Type profiling of return value at call; "          \
2873                      "X: Type profiling of parameters to methods; "         \
2874           "X, Y and Z in 0=off ; 1=jsr292 only; 2=all methods")             \
2875           range(0, 222)        

Legal values are 0, 1, 2, 10, 11, 12, 100, 101, 102, 110, 111, 112 etc.

70 is not for instance. So range(0, 222) is incorrect.

2877   product(intx, TypeProfileArgsLimit,     2,                                \
2878           "max number of call arguments to consider for type profiling")    \
2879           range(0, 16)                                                      \

2880                                                                             \
2881   product(intx, TypeProfileParmsLimit,    2,                                \
2882           "max number of incoming parameters to consider for type profiling"\
2883           ", -1 for all")                                                   \
2884           range(-1, 64)   

Why 16 and 64?

Roland.