RFR(S): 8138733: Fix build: gcc < 4.8 doesn't grok -Wno-format-zero-length added in 8080775
Mikael Gerdin
mikael.gerdin at oracle.com
Fri Oct 2 11:05:42 UTC 2015
Redirecting to hotspot-dev at ...
On 2015-10-02 12:58, Lindenmaier, Goetz wrote:
> Hi,
>
> We appreciate change 8080775 a lot, but it breaks the build with older gcc.
>
> They don’t know the option -Wno-format-zero-length.
>
> To fix this, I only add -Wno-format-zero-length for gcc >= 4.8.
>
> For the other gccs, I remove ATTRIBUTE_PRINTF from the declaration of
>
> report_vm_error().
>
> This is no big deal, as correctness is guaranteed once it’s compiled with
>
> gcc 4.8.
>
> I had to fix one fatal() in the ppc files, too.
>
> Please review this change. I please need a sponsor.
>
> http://cr.openjdk.java.net/~goetz/webrevs/8138733-warn/webrev.00/
>
> Best regards,
>
> Goetz.
>
More information about the hotspot-compiler-dev
mailing list