[9] RFR(S): 8138651: -XX:DisableIntrinsic matches intrinsics overly eagerly

[Zoltán Majó]

Thank, Vladimir and Aleksey, for the feedback!

I'll put this issue on hold until Nils has pushed his work on compiler 
control and will produce an updated version then.

Best regards,


Zoltan

On 10/07/2015 04:37 AM, Vladimir Kozlov wrote:
> To be precise DisableIntrinsic is ccstrlist option, not ccstr. Yes, 
> the actual type is the same.
>
> An other concern is separators since format could be different if 
> option specified in file. Look how we do search in DeoptimizeOnlyAt 
> string.
>
> Thanks,
> Vladimir
>
> On 10/6/15 8:00 PM, Zoltán Majó wrote:
>> Hi,
>>
>>
>> please review the patch for JDK-8138651.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8138651
>>
>> Problem: The DisableIntrinsic flag does not disable intrinsics
>> accurately. For example, -XX:DisableIntrinsic=_copyOfRange disables both
>> the intrinsic with the ID _copyOfRange and the intrinsic with the 
>> _copyOf.
>>
>> Solution: Change the processing of the DisableIntrinsic flag (both
>> globally and on a per-method level).
>>
>> Webrev: http://cr.openjdk.java.net/~zmajo/8138651/webrev.00/
>>
>> Testing:
>> - JPRT (testset hotspot);
>> - executed the the newly added test
>> compiler/intrinsics/IntrinsicDisabledTest.java with/without the fix on
>> all platforms, the test behaves as expected.
>>
>> Thank you and best regards,
>>
>>
>> Zoltan
>>