[9] RFR(S): 8137160: Use Compile::live_nodes instead of Compile::unique() in appropriate places -- followup

Vladimir Kozlov vladimir.kozlov at oracle.com
Wed Oct 7 14:24:49 UTC 2015


Looks good.

Thanks,
Vladimir

On 10/7/15 10:20 PM, Zoltán Majó wrote:
> Hi,
>
>
> please review the following patch for JDK-8137160.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8137160
>
> Problem: JDK-8011858 changed memory allocation for compiler-related data
> structures to use Compile::live_nodes() instead of
> Compile::unique_nodes() to reduce the C2 compiler's memory usage. While
> backporting JDK-8011858 to 8u72, we discovered two code locations where
> live_nodes() and be used instead of unique_nodes().
>
> Solution: This patch changes allocation at the above-mentioned two code
> locations to use live_nodes() instead of unique_nodes(). The patch also
> updates comments so that they match the source code.
>
> Webrev:
> http://cr.openjdk.java.net/~zmajo/8137160/webrev.00/
>
> Testing:
> - JPRT, all tests pass;
> - all hotspot tests executed locally; all tests pass that pass with an
> unmodified VM.
>
> Thank you and best regards,
>
>
> Zoltan
>


More information about the hotspot-compiler-dev mailing list