[9] RFR(S): 8139375: [TESTBUG] compiler/jvmci/SecurityRestrictionsTest checks are too tight

Tatiana Pivovarova tatiana.pivovarova at oracle.com
Mon Oct 12 18:19:09 UTC 2015


Thanks for review, Christian!
---
Tatiana

On 10/12/2015 09:05 PM, Christian Thalinger wrote:
> Looks good.
>
>> On Oct 12, 2015, at 7:39 AM, Tatiana Pivovarova 
>> <tatiana.pivovarova at oracle.com 
>> <mailto:tatiana.pivovarova at oracle.com>> wrote:
>>
>> Hello guys,
>>
>> Please review this small patch
>> When we use JVMCI functions without permissions we expect 
>> AccessControlException. But this exception raises not explicitly. It 
>> causes other exception (for example ExceptionInInitializerError).
>> This patch add a workaround: we got the deepest cause and check that 
>> it is AccessControlException. Also I slightly changed 
>> Utils::runAndCheckException(Runnable runnable, Class<? extends 
>> Throwable> expectedException) to ensure that this changes don't break 
>> other tests which use this function.
>>
>> bug id: https://bugs.openjdk.java.net/browse/JDK-8139375
>> webrev: http://cr.openjdk.java.net/~tpivovarova/8139375/webrev.00/
>> ---
>> Thanks,
>> Tatiana
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151012/ebcd24da/attachment.html>


More information about the hotspot-compiler-dev mailing list