RFR(XS) : 8139376 : [TESTBUG] ExecuteInstalledCodeTest should be run only on amd64 and sparcv9

Christian Thalinger christian.thalinger at oracle.com
Tue Oct 13 19:23:32 UTC 2015


> On Oct 13, 2015, at 5:26 AM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> Hi Vladimir,
> 
> 'os.arch != "aarch64"' is a workaround for a bug in jtreg[*].
> 
> [*] https://bugs.openjdk.java.net/browse/CODETOOLS-7901514

Wow, this is really stupid:

- if (arch.contains("64") && !arch.equals("ia64") && !arch.equals("ppc64")) 
+ if (arch.equals("amd64") || arch.equals("x86_64")) 

> 
> Igor
> 
> On 10/13/2015 05:35 PM, Vladimir Kozlov wrote:
>> I don't think this is correct (we also have ppc):
>> 
>>  & os.arch != "aarch64"
>> 
>> why you need it? Why first condition is not enough:
>> (os.simpleArch == "x64" | os.simpleArch == "sparcv9")
>> 
>> Thanks,
>> Vladimir
>> 
>> On 10/13/15 9:30 PM, Igor Ignatyev wrote:
>>> http://cr.openjdk.java.net/~iignatyev/8139376/webrev.00/
>>>> 1 line changed: 1 ins; 0 del; 0 mod;
>>> 
>>> Hi all,
>>> 
>>> please review the small fix which adds '@requires' to exclude
>>> compiler/jvmci/compilerToVM/ExecuteInstalledCodeTest from running on
>>> platforms which don't support JMVCI.
>>> 
>>> webrev: http://cr.openjdk.java.net/~iignatyev/8139376/webrev.00/
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8139376
>>> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151013/85a26fc9/attachment-0001.html>


More information about the hotspot-compiler-dev mailing list