RFR (XS): 8139558 [JVMCI] SPARC hits: guarantee(heap_end < allocation_end) failed: heap end too close to end of address space (might lead to erroneous TLAB allocations)

Christian Thalinger christian.thalinger at oracle.com
Wed Oct 14 19:23:07 UTC 2015


> On Oct 13, 2015, at 4:15 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> 
> Okay. I saw this fix in JVMCI refresh changes.

Right, but we need to push it separately in order to avoid the noise in nightly testing.  Thanks for the review.

> 
> Thanks,
> Vladimir
> 
> On 10/14/15 3:02 AM, Christian Thalinger wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8139558
>> 
>> This assert can trigger trivially on SPARC so we have to disable it.
>> 
>> diff -r 0ca52fb7d980 src/share/vm/jvmci/jvmciRuntime.cpp
>> --- a/src/share/vm/jvmci/jvmciRuntime.cppTue Sep 29 17:01:37 2015 +0000
>> +++ b/src/share/vm/jvmci/jvmciRuntime.cppTue Oct 13 09:02:29 2015 -1000
>> @@ -778,9 +778,11 @@ JVM_ENTRY(void, JVM_RegisterJVMCINatives
>>    }
>> 
>> 
>>  #ifdef _LP64
>> +#ifndef TARGET_ARCH_sparc
>>    uintptr_t heap_end = (uintptr_t)
>> Universe::heap()->reserved_region().end();
>>    uintptr_t allocation_end = heap_end + ((uintptr_t)16) * 1024 * 1024
>> * 1024;
>>    guarantee(heap_end < allocation_end, "heap end too close to end of
>> address space (might lead to erroneous TLAB allocations)");
>> +#endif // TARGET_ARCH_sparc
>>  #else
>>    fatal("check TLAB allocation code for address space conflicts");
>>  #endif
>> 



More information about the hotspot-compiler-dev mailing list