RFR(S): JDK-8139438: [TESTBUG] JVMCI test fails with RuntimeException: Has no virtual object before materialization

[Christian Thalinger]

> On Oct 14, 2015, at 1:34 PM, Igor Ignatyev <igor.ignatyev at oracle.com> wrote:
> 
> Hi Chris,
> 
> Thanks for review. we will address your comment later as a fix for RFE(JDK-8139619) if you don’t mind.

Sure.

> 
> Thanks,
> - Igor 
> 
>> On Oct 15, 2015, at 2:13 AM, Christian Thalinger <christian.thalinger at oracle.com <mailto:christian.thalinger at oracle.com>> wrote:
>> 
>> 
>>> On Oct 14, 2015, at 8:29 AM, Dmitrij Pochepko <dmitrij.pochepko at oracle.com <mailto:dmitrij.pochepko at oracle.com>> wrote:
>>> 
>>> Hi,
>>> 
>>> an issue with 1st version was found: a getDeclaredMethod parameter(line 67) wasn't changed according to testFrame method signature change.
>>> Now changed from Integer.class boolean.class
>>> 
>>> Please take a look at 2nd version: http://cr.openjdk.java.net/~dpochepk/8139438/webrev.02 <http://cr.openjdk.java.net/~dpochepk/8139438/webrev.02>
>> 
>> +        int levels[] = CompilerUtils.getAvailableCompilationLevels();
>> +        // we need compilation level 4 to use EscapeAnalysis
>> +        if (levels.length < 1 || levels[levels.length - 1] != 4) {
>> 
>> To be more robust against future changes of this WB method you should search the array for level 4 instead of assuming it’s in the last element.
>> 
>> Otherwise this looks good.
>> 
>>> 
>>> Thanks,
>>> Dmitrij
>>> 
>>> On 13.10.2015 23:15, Dmitrij Pochepko wrote:
>>>> Hi, 
>>>> 
>>>> please review a small fix for test: compiler/jvmci/compilerToVM/MaterializeVirtualObjectTest.java 
>>>> 
>>>> Description:
>>>> 
>>>> A test is changed to run testcases in separate VM launch instead of consecutive execution, which had wrong assumption about method compilation state in case of -XX:-TieredCompilation.
>>>> So, a boolean system property is added into test to control test execution logic externally.
>>>> I've also added minor code cleanup.
>>>> 
>>>> webrev: http://cr.openjdk.java.net/~dpochepk/8139438/webrev.01/ <http://cr.openjdk.java.net/%7Edpochepk/8139438/webrev.01/> 
>>>> 
>>>> Thanks, 
>>>> Dmitrij
>>> 
>> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151014/97d6085f/attachment-0001.html>