[9] RFR(S): 8139380: VMError::report_and_die() does not produce replay file
Zoltán Majó
zoltan.majo at oracle.com
Fri Oct 16 11:10:33 UTC 2015
Hi,
please review the patch for 8139380.
Bug: https://bugs.openjdk.java.net/browse/JDK-8139380
Problem: The test compiler/ciReplay/TestVM.sh intentionally crashes the
VM and expects compiler replay data to be saved into a file
('test_replay.txt'). Since the JVMCI changes were pushed, the test fails
on some platforms we support because the file is not created by the VM.
The file should be created by VMError::report_and_die(). However, a
SIGSEGV is thrown in VMError::report() (report() is called by
report_and_die()) that causes the VM to exit without saving replay data.
Solution: Update VMError::report() to use an appropriate format string
to print the VM version in both JVMCI-enabled builds and builds without
JVMCI.
Webrev:
http://cr.openjdk.java.net/~zmajo/8139380/webrev.00/
Testing:
- JPRT (testset hotspot);
- executed failing test on all supported platforms, the failure is not
triggered.
Thank you and best regards,
Zoltan
More information about the hotspot-compiler-dev
mailing list