RFR(M) 8138892: C1: Improve counter overflow checking

[Lindenmaier, Goetz]

Hi,

Anyways, I double-checked that these three reviewed changes import, jcheck and build fine:
8138890: C1: Ambiguous operator delete
http://cr.openjdk.java.net/~mdoerr/8138890_c1_ambiguous_delete/webrev.03/main-hotspot-xxx.changeset
8138894: C1: Support IRIW on weak memory platforms
http://cr.openjdk.java.net/~mdoerr/8138894_c1_IRIW/webrev.01/main-hotspot-xxx.changeset
8138892: C1: Improve counter overflow checking
http://cr.openjdk.java.net/~mdoerr/8138892_c1_counter_overflow/webrev.03/main-hotspot-xxx.changeset

Christian, thanks a lot for helping us. I appreciate this a lot!

Best regards,
  Goetz.



From: Doerr, Martin
Sent: Mittwoch, 21. Oktober 2015 11:54
To: Christian Thalinger; Lindenmaier, Goetz
Cc: hotspot compiler
Subject: RE: RFR(M) 8138892: C1: Improve counter overflow checking

Hi Christian,

I have uploaded the final webrev and attached this changeset to the bug in JIRA:
http://cr.openjdk.java.net/~mdoerr/8138892_c1_counter_overflow/webrev.03/main-hotspot-xxx.changeset
It contains the reviewers.

I have also attached a changeset with reviewers to the operator delete change:
https://bugs.openjdk.java.net/browse/JDK-8138890

Best regards,
  Martin


From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of Christian Thalinger
Sent: Mittwoch, 21. Oktober 2015 02:04
To: Lindenmaier, Goetz
Cc: hotspot compiler
Subject: Re: RFR(M) 8138892: C1: Improve counter overflow checking


On Oct 20, 2015, at 2:01 PM, Christian Thalinger <christian.thalinger at oracle.com<mailto:christian.thalinger at oracle.com>> wrote:

Btw. it would help if you could export a changeset with the correct commit message and send it as attachment to the list.

Even better, attach it to the JIRA issue.


On Oct 20, 2015, at 1:58 PM, Christian Thalinger <christian.thalinger at oracle.com<mailto:christian.thalinger at oracle.com>> wrote:

Sorry, I’m pretty busy but I will try to sponsor this.

On Oct 11, 2015, at 10:58 PM, Lindenmaier, Goetz <goetz.lindenmaier at sap.com<mailto:goetz.lindenmaier at sap.com>> wrote:

Hi Martin,

this change looks good, thank you.

Could someone please sponsor this?

Best regards,
  Goetz.

From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces at openjdk.java.net]On Behalf Of Doerr, Martin
Sent: Mittwoch, 7. Oktober 2015 23:02
To: hotspot compiler; Andrew Haley (aph at redhat.com<mailto:aph at redhat.com>)
Subject: RFR(M) 8138892: C1: Improve counter overflow checking

Hi,

C1 currently loads the Method pointer in the fast path even though it is only required in the overflow case. In addition, stupid code gets generated when the frequency is set to 0 which occurs with -Xcomp.

The following webrev optimizes that:
http://cr.openjdk.java.net/~mdoerr/8138892_c1_counter_overflow/webrev.02

It’s not tested on aarch64.

Please review this change.  I need a sponsor, please.

Best regards,
  Martin



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20151021/46e12db6/attachment-0001.html>