RFR(XS): 8140239: Fix product build after "8132168: Support IdealGraphVisualizer in optimized build"

[Lindenmaier, Goetz]

Hi Vladimir, 

thanks for pushing the change!

Best regards,
  Goetz.

> -----Original Message-----
> From: Vladimir Ivanov [mailto:vladimir.x.ivanov at oracle.com]
> Sent: Mittwoch, 21. Oktober 2015 17:10
> To: Lindenmaier, Goetz; hotspot compiler
> Subject: Re: RFR(XS): 8140239: Fix product build after "8132168: Support
> IdealGraphVisualizer in optimized build"
> 
> Sure, looks good.
> 
> Best regards,
> Vladimir Ivanov
> 
> On 10/21/15 5:34 PM, Lindenmaier, Goetz wrote:
> > Hi Vladimir,
> >
> > I just tried to implement the same behavior as with 'develop'.
> > But excluding the flag altogether is fine with me, too:
> > http://cr.openjdk.java.net/~goetz/webrevs/8140239-prodBld/webrev.01/
> > I put in you as reviewer, if that's ok.
> >
> > Best regards,
> >    Goetz.
> >
> >
> >
> >
> >> -----Original Message-----
> >> From: Vladimir Ivanov [mailto:vladimir.x.ivanov at oracle.com]
> >> Sent: Mittwoch, 21. Oktober 2015 15:45
> >> To: Lindenmaier, Goetz; hotspot compiler
> >> Subject: Re: RFR(XS): 8140239: Fix product build after "8132168: Support
> >> IdealGraphVisualizer in optimized build"
> >>
> >> Goetz, thanks for spotting that!
> >>
> >> Why not simply exclude IGVPrintLevel in product binaries instead?
> >>
> >> -    cflags(IGVPrintLevel,           intx, PrintIdealGraphLevel,
> >> IGVPrintLevel) \
> >> +    NOT_PRODUCT(cflags(IGVPrintLevel, intx, PrintIdealGraphLevel,
> >> IGVPrintLevel)) \
> >>
> >> IGVPrintLevel is used only in non-product code and PrintIdealGraphLevel
> >> functionality is not available in product builds.
> >>
> >> Best regards,
> >> Vladimir Ivanov
> >>
> >> PS: I'm surprised the problem wasn't caught by JPRT. Shouldn't the
> >> merged version be tested? It looks like the merge [1] happened after the
> >> job finished. (FTR I had to restart the job due to a timeout.)
> >>
> >> [1] http://hg.openjdk.java.net/jdk9/hs-comp/hotspot/rev/03fa0a35a468
> >>
> >> On 10/21/15 3:50 PM, Lindenmaier, Goetz wrote:
> >>> Hi,
> >>>
> >>> After "8132168: Support IdealGraphVisualizer in optimized build" the
> >>> product build is broken:
> >>> compilerDirectives.cpp:181: error: 'PrintIdealGraphLevel' was not
> >>> declared in this scope
> >>>
> >>> 8132168 changes the flag from 'develop' to 'notproduct'. 'Notproduct'
> >>> does not define
> >>> "const intx PrintIdealGraphLevel = 0;" in the product build, as
> >>> 'develop' did.
> >>>
> >>> I fixed this by wrapping the flag with NOT_PRODUCT:
> >>>
> >>> http://cr.openjdk.java.net/~goetz/webrevs/8140239-
> prodBld/webrev.00/
> >>>
> >>> Please review this change.  I please need a sponsor.
> >>>
> >>> Best regards,
> >>>
> >>>     Goetz.
> >>>