[9] RFR(S): 8138651: -XX:DisableIntrinsic matches intrinsics overly eagerly

[Zoltán Majó]

Hi Vladimir,


thank you for the review!

On 10/23/2015 11:42 AM, Vladimir Kozlov wrote:
> [...]
>> This inconsistency should be addressed, but as the fix requires
>> significant changes to CompilerOracle, I would like to take care of that
>> separately. I've filed an RFE for that:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8140322
>>
>> I hope that is fine.
>
> Yes, it is fine to fix separately.
>
>>
>> Here is the updated webrev:
>> http://cr.openjdk.java.net/~zmajo/8138651/webrev.01/
>
> Will you update later (in next rfe) next method to print all items on 
> list 'v'? Should it be 'ccstrlist v'?:
>
> +   void print_ccstrlist(outputStream* st, ccstr n, ccstr v, bool mod) 
> { print_ccstr(st, n, v, mod); }

Yes, you are right, changing the argument type to 'ccstrlist v' would 
make the code clearer and printing list items would also make sense. I 
noted this problem in the description of JDK-8140322.

Thank you and best regards,


Zoltan


>
> Otherwise changes looks good.
>
> Thanks,
> Vladimir
>
>>
>> Testing:
>> - JPRT (testset hotspot, including the newly added
>> IntrinsicDisabledTest.java test).
>>
>> Thank you and best regards,
>>
>>
>> Zoltan
>>
>>>
>>> Thanks,
>>> Vladimir
>>>
>>> On 10/6/15 8:00 PM, Zoltán Majó wrote:
>>>> Hi,
>>>>
>>>>
>>>> please review the patch for JDK-8138651.
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8138651
>>>>
>>>> Problem: The DisableIntrinsic flag does not disable intrinsics
>>>> accurately. For example, -XX:DisableIntrinsic=_copyOfRange disables 
>>>> both
>>>> the intrinsic with the ID _copyOfRange and the intrinsic with the
>>>> _copyOf.
>>>>
>>>> Solution: Change the processing of the DisableIntrinsic flag (both
>>>> globally and on a per-method level).
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~zmajo/8138651/webrev.00/
>>>>
>>>> Testing:
>>>> - JPRT (testset hotspot);
>>>> - executed the the newly added test
>>>> compiler/intrinsics/IntrinsicDisabledTest.java with/without the fix on
>>>> all platforms, the test behaves as expected.
>>>>
>>>> Thank you and best regards,
>>>>
>>>>
>>>> Zoltan
>>>>
>>