RFR: 8140611: aarch64: jtreg test jdk/tools/pack200/UnpackerMemoryTest.java SEGVs
Vladimir Kozlov
vladimir.kozlov at oracle.com
Wed Oct 28 02:59:36 UTC 2015
Good.
Thanks,
Vladimir
On 10/28/15 2:20 AM, Edward Nevill wrote:
> Hi,
>
> Please review the following webrev
>
> http://cr.openjdk.java.net/~enevill/8140611/webrev/
>
> JIRA Issue: https://bugs.openjdk.java.net/browse/JDK-8140611
>
> Summary: The UnpackerMemoryTest SEGVs in jni_GetStringUTFChars.
>
> The problem is that c_rarg3 is a really bad choice for a tmp register since at this point the native arguments have been loaded into registers. (I confess guilt for this).
>
> 'lr' is a much better choice for the tmp register. We know this is free because we are just about to do a 'rt_call' which clobbers lr in any case.
>
> Thanks for the review,
> Ed.
>
>
More information about the hotspot-compiler-dev
mailing list